bkyryliuk commented on pull request #10963: URL: https://github.com/apache/incubator-superset/pull/10963#issuecomment-698451673
> **Note:** > For explore_json requests, we want to cache **query results**. > > For dashboard requests, we want to cache **dashboard bootstrap data**, which includes datasource metadata, slices parameters, etc. Dashboard front-end js use datasource metadata, slice parameters, and dashboard filters to build query and fetch query results, the **results itself are not in the dashboard bootstrap data**. > > This PR will only focus on dashboard's cache stale logic. i do not want to change current slice cache behavior. > > #2 > if chart **was not modified for ~10 hours**, I assume this means `slice` entity are not modified, like query parameters, datasource used, it doesn't mean the **query results** is not modified. Since query results is not part of dashboard bootstrap data, it's not included in the dashboard cache either. > > #3: > annotations: dashboard has no annotation. If slice's annotation was changed, slice entity's `params` and `changed_on` attribute will be changed. > changed to the default filters, css rules, etc: these change will be stored in dashboard metadata, and will change dashboard `changed_on` attribute. Big thanks for the explanation! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
