suddjian commented on pull request #10936:
URL: 
https://github.com/apache/incubator-superset/pull/10936#issuecomment-699078760


   > @suddjian according to 
[SIP-45](https://github.com/apache/incubator-superset/issues/9935) discussion, 
when one or more filters are not applicable to the chart, we will still show 
the chart with query results, but not applied with wrong filter_fields. We 
should not show "No Results".
   
   The chart in the screenshot is only showing "No Results" because there 
genuinely are no results for that query. That is not because of the filters 
being unapplicable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to