[GitHub] [incubator-superset] mistercrunch opened a new pull request #11075: style(sqllab): make database errors more clear and render as monospace

[GitBox]

mistercrunch opened a new pull request #11075:
URL: https://github.com/apache/incubator-superset/pull/11075


   In SQL Lab, when a database error message is returned, generally because
   of a user error in the SQL, it's identified as an "Unexpected Error" and
   some of the text formatting of the error message (\n, spaces, tabs, ...)
   are lost as they are rendered in html.
   
   This PR identifies the error as a "Database Error", and renders like
   more like a <pre>, using a monospace font.
   
   ## after
   <img width="1304" alt="Screen Shot 2020-09-25 at 10 40 51 PM" 
src="https://user-images.githubusercontent.com/487433/94331417-ffc1a900-ff80-11ea-93ba-7d0f21fb373f.png";>
   
   ## before
   <img width="1303" alt="Screen Shot 2020-09-25 at 10 48 27 PM" 
src="https://user-images.githubusercontent.com/487433/94331453-4c0ce900-ff81-11ea-888b-9f4480449fff.png";>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org