rusackas commented on pull request #10982: URL: https://github.com/apache/incubator-superset/pull/10982#issuecomment-700326371
> @rusackas @ktmud Thank you for your suggestions. Before you suggested using `styled` and styles from superset-ui, I wrote some css of my own that removed the excessive margin and added permanent scrollbar. Do you think I should refactor or can we go with what we currently have? I would prefer the refactor if it's possible, for a few reasons: 1) We're trying to make the LESS codebase smaller, rather than add anything more to it (we'd like to one day remove these global file styles, if it becomes possible). 2) Add the styles within the components that they concern, so that future people can refactor/add/remove styles more easily (i.e. within the components, thus the shift to Emotion) 3) You could use Theme variables... in the CSS on this PR, for example, you could use the 4px `gridUnit`(or multiples of it) used in an increasing number of places in superset. The idea here is that no fonts/sizes/colors should be hard-coded in an effort to eventually make Superset more themeable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
