graceguo-supercat commented on a change in pull request #10963:
URL:
https://github.com/apache/incubator-superset/pull/10963#discussion_r496461532
##########
File path: superset/utils/decorators.py
##########
@@ -46,7 +46,12 @@ def stats_timing(stats_key: str, stats_logger:
BaseStatsLogger) -> Iterator[floa
stats_logger.timing(stats_key, now_as_float() - start_ts)
-def etag_cache(max_age: int, check_perms: Callable[..., Any]) -> Callable[...,
Any]:
+def etag_cache(
+ max_age: int,
+ check_perms: Callable[..., Any],
+ get_latest_changed_on: Optional[Callable[..., Any]] = None,
Review comment:
agree. rename it to `get_last_modified`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
