villebro commented on a change in pull request #11103:
URL:
https://github.com/apache/incubator-superset/pull/11103#discussion_r496561535
##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -106,15 +107,13 @@ def _flatten_column_after_pivot(
:param aggregates: aggregates
:return:
"""
- if isinstance(column, str):
- return column
- if len(column) == 1:
- return column[0]
+ if not isinstance(column, tuple):
+ column = (column,)
if len(aggregates) == 1 and len(column) > 1:
# drop aggregate for single aggregate pivots with multiple groupings
# from column name (aggregates always come first in column name)
column = column[1:]
- return ", ".join(column)
+ return ", ".join([str(col) for col in column])
Review comment:
It's a shame we have to format everything as strings for now, but hoping
to remedy this once we move on to some other serialization format than JSON.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
