john-bodley edited a comment on pull request #11099: URL: https://github.com/apache/incubator-superset/pull/11099#issuecomment-700861841
@etr2460 I think it depends (per your comments) on whether the errors are supposed to be engine or Superset centric. If it’s the later then I think having universal errors makes sense though the wording probably needs to be more aligned with the Superset vernacular. Note per the screenshots it messages do state "Presto Error" and thus it does currently seem more engine centric. That said my comments are non-blocking. I don't see there being any real issues if the wording of these errors changes over time not perceive there to be any major costs with updating/refactoring the code if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
