dpgaspar commented on a change in pull request #10836:
URL:
https://github.com/apache/incubator-superset/pull/10836#discussion_r498086479
##########
File path: superset/charts/api.py
##########
@@ -503,6 +504,50 @@ def data(self) -> Response:
return response
+ @expose("/data/stop", methods=["POST"])
+ @event_logger.log_this
+ @protect()
+ @safe
+ @statsd_metrics
+ def data_stop(self) -> Response:
+ """
+ Takes a dashboard id and tries to cancel all associated chart data
requests
+ issued by the user.
+ ---
+ post:
+ description: >-
+ Takes a dashboard id and tries to cancel all associated chart data
requests
+ issued by the user
+ requestBody:
+ description: >-
+ The dashboard id.
+ required: true
+ content:
+ application/json:
+ schema:
+ $ref: "#/components/schemas/ChartDataStopSchema"
+ responses:
+ 200:
+ description: Pending dashboard queries terminated
+ content:
+ application/json:
+ schema:
+ type: object
Review comment:
We don't need `content` on a empty response, also see if HTTP 204 makes
sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
