eschutho commented on a change in pull request #11181:
URL:
https://github.com/apache/incubator-superset/pull/11181#discussion_r500652435
##########
File path:
superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -267,7 +267,7 @@ export default class AdhocFilterControl extends
React.Component {
<OnPasteSelect
isMulti
name={`select-${this.props.name}`}
- placeholder={t('choose a column or metric')}
+ placeholder={t('choose one or more column or metric')}
Review comment:
I don't have strong opinions on whether this should be singular or
plural "column/columns" and "metric/metrics", and it seems the grammar
guidelines are loose as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
