mistercrunch commented on a change in pull request #11118:
URL:
https://github.com/apache/incubator-superset/pull/11118#discussion_r500741691
##########
File path:
superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -17,12 +17,12 @@
* under the License.
*/
import React from 'react';
-import { Tabs } from 'react-bootstrap';
import { shallow } from 'enzyme';
import configureStore from 'redux-mock-store';
import fetchMock from 'fetch-mock';
import thunk from 'redux-thunk';
+import Tabs from 'src/common/components/Tabs';
Review comment:
Let's follow the same pattern as for `'src/components/Popover/index.tsx`
where we have a placeholder file and all internal references point to that
file. This will allow us to re-style alter/refactor all in one place in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
