rusackas commented on a change in pull request #11134:
URL:
https://github.com/apache/incubator-superset/pull/11134#discussion_r500749777
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/visualizations/pivot_table.test.js
##########
@@ -66,42 +66,70 @@ describe('Visualization > Pivot Table', () => {
it('should work with single groupby', () => {
verify(PIVOT_TABLE_FORM_DATA);
- cy.get('.chart-container tr:eq(0) th:eq(1)').contains('sum__num');
- cy.get('.chart-container tr:eq(1) th:eq(0)').contains('state');
- cy.get('.chart-container tr:eq(2) th:eq(0)').contains('name');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(1)')
+ .contains('sum__num');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(1) th:eq(0)')
+ .contains('state');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(0)')
+ .contains('name');
});
it('should work with more than one groupby', () => {
verify({
...PIVOT_TABLE_FORM_DATA,
groupby: ['name', 'gender'],
});
- cy.get('.chart-container tr:eq(0) th:eq(2)').contains('sum__num');
- cy.get('.chart-container tr:eq(1) th:eq(1)').contains('state');
- cy.get('.chart-container tr:eq(2) th:eq(0)').contains('name');
- cy.get('.chart-container tr:eq(2) th:eq(1)').contains('gender');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(2)')
+ .contains('sum__num');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(1) th:eq(1)')
+ .contains('state');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(0)')
+ .contains('name');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(1)')
+ .contains('gender');
});
it('should work with multiple metrics', () => {
verify({
...PIVOT_TABLE_FORM_DATA,
metrics: ['sum__num', TEST_METRIC],
});
- cy.get('.chart-container tr:eq(0) th:eq(1)').contains('sum__num');
- cy.get('.chart-container tr:eq(0) th:eq(2)').contains('SUM(sum_boys)');
- cy.get('.chart-container tr:eq(1) th:eq(0)').contains('state');
- cy.get('.chart-container tr:eq(2) th:eq(0)').contains('name');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(1)')
+ .contains('sum__num');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(0) th:eq(2)')
+ .contains('SUM(sum_boys)');
+ cy.get('[data-test="chart-container"]').find('th:eq(0)').contains('state');
+ cy.get('[data-test="chart-container"]')
+ .find('tr:eq(2) th:eq(0)')
+ .contains('name');
});
- it('should work with multiple groupby and multiple metrics', () => {
+ it.only('should work with multiple groupby and multiple metrics', () => {
Review comment:
I don't believe we want the `.only` here, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
