john-bodley edited a comment on pull request #11194: URL: https://github.com/apache/incubator-superset/pull/11194#issuecomment-705266764
@mistercrunch I per the guidelines I think reverting made sense: > Availability of the PR author: If the original PR author or the engineer who merged the code is highly available and can provide a fix in a reasonable timeframe, this would counter-indicate reverting. Unclear. @kgabryje is a relatively new contributor. > Severity of the issue: How severe is the problem on master? Is it keeping the project from moving forward? Is there user impact? What percentage of users will experience a problem? SQL Lab is unusable for result sets with a moderate number of columns. > Size of the change being reverted: Reverting a single small PR is a much lower-risk proposition than reverting a massive, multi-PR change. The PR was self contained and reverted without conflict, thus the risk proposition seemed quite low. > Age of the change being reverted: Reverting a recently-merged PR will be more acceptable than reverting an older PR. A bug discovered in an older PR is unlikely to be causing widespread serious issues. The PR is relatively new and was merged 5 days ago. > Risk inherent in reverting: Will the reversion break critical functionality? Is the medicine more dangerous than the disease? Difficulty of crafting a fix: In the case of issues with a clear solution, it may be preferable to implement and merge a fix rather than a revert. The risk is low especially as this was a new feature and the previous state was deemed stable. It is unclear how trivial it is to craft a fix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
