ktmud commented on pull request #11160:
URL: 
https://github.com/apache/incubator-superset/pull/11160#issuecomment-705763689


   Not a designer, but I also feel the original design is a cleaner and better 
user experience. It'd be a little weird to have different visual styles (line 
vs card) for tabs in View and in Edit modes.
   
   In general, we should probably limit style changes when replacing Bootstrap 
components. For this case, it'd be easier and less risky if we had just kept 
the original editing functionalities and only replaced the `BootstrapTabs` 
component itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to