zhaoyongjie commented on a change in pull request #11060:
URL: 
https://github.com/apache/incubator-superset/pull/11060#discussion_r502733019



##########
File path: superset/viz.py
##########
@@ -341,6 +341,9 @@ def process_query_filters(self) -> None:
         utils.convert_legacy_filters_into_adhoc(self.form_data)
         merge_extra_filters(self.form_data)
         utils.split_adhoc_filters_into_base_filters(self.form_data)
+        # Normalize various filters, and then remove the original filters
+        self.form_data.pop("adhoc_filters", None)
+        self.form_data.pop("extra_filters", None)

Review comment:
       I want to put all of modifying the filter together




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to