john-bodley opened a new pull request #11223: URL: https://github.com/apache/incubator-superset/pull/11223
### SUMMARY The SQLAlchemy dialect has a [`do_ping`](https://github.com/sqlalchemy/sqlalchemy/blob/056c929e15c735059b2f17f9ae5391d3ad244907/lib/sqlalchemy/engine/default.py#L624) method for pinging the database engine (which defaults to running a `SELECT 1`). Certain dialects/drivers override this and thus I thought there was merit in replacing the explicit `SELECT 1` query when testing the connection with the SQLAlchemy abstraction. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN Unit tests. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
