mistercrunch commented on a change in pull request #11227:
URL:
https://github.com/apache/incubator-superset/pull/11227#discussion_r502824304
##########
File path: superset/views/utils.py
##########
@@ -351,11 +351,11 @@ def build_extra_filters( # pylint:
disable=too-many-locals,too-many-nested-bloc
for filter_id, columns in default_filters.items():
filter_slice =
db.session.query(Slice).filter_by(id=filter_id).one_or_none()
- filter_configs = (
- json.loads(filter_slice.params or "{}").get("filter_configs") or []
- if filter_slice
- else []
- )
+ filter_configs: List[Dict[str, Any]] = []
Review comment:
Somehow `mypy` + `pre-commit` were picking up on this, unclear why as i
didn't touch the file. Added type annotations here to move forward...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
