ktmud commented on a change in pull request #11234:
URL:
https://github.com/apache/incubator-superset/pull/11234#discussion_r503554297
##########
File path: superset/models/dashboard.py
##########
@@ -239,6 +248,41 @@ def data(self) -> Dict[str, Any]:
"position_json": positions,
}
+ @cache.memoize(
+ # manually maintain cache key version
+ make_name=lambda fname: f"{fname}-v1",
+ timeout=config["DASHBOARD_CACHE_TIMEOUT"],
+ unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
+ )
+ def full_data(
+ self,
+ reduce_payload: bool =
is_feature_enabled("REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD"),
Review comment:
Either way works. But it sure will make this PR cleaner if it's merged
before this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
