graceguo-supercat commented on a change in pull request #11210:
URL: 
https://github.com/apache/incubator-superset/pull/11210#discussion_r503654091



##########
File path: 
superset-frontend/spec/javascripts/explore/components/FilterBox_spec.jsx
##########
@@ -58,4 +59,30 @@ describe('FilterBox', () => {
     inst.setState({ selectedValues: { name: 'James' } });
     expect(inst.props.filtersChoices.name.length).toEqual(3);
   });
+
+  it('should support granularity_sqla options', () => {

Review comment:
       added a dumb unit test. Time range filter box will soon be replaced by 
dashboard component.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to