[GitHub] [incubator-superset] lilykuang opened a new pull request #11258: chore: update dashboard edit modal UI

[GitBox]

lilykuang opened a new pull request #11258:
URL: https://github.com/apache/incubator-superset/pull/11258


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - switch the positions of `save` and `cancel` buttons
   - add border for JSON METADATA text field
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   before:
   ![Screen Shot 2020-10-13 at 5 16 31 
PM](https://user-images.githubusercontent.com/5705598/95929409-c8bd0700-0d78-11eb-8649-b2d78ab37324.png)
   after:
   ![Screen Shot 2020-10-13 at 5 15 43 
PM](https://user-images.githubusercontent.com/5705598/95929421-ce1a5180-0d78-11eb-87b0-38d54c52b315.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org