zuzana-vej commented on issue #11190: URL: https://github.com/apache/incubator-superset/issues/11190#issuecomment-708521731
So basically editing dataset on the edit dataset modal (screenshot in my previous message) will be applied locally to the chart. It's just another way to do it (in case user is already on the modal). I think that makes sense. I question whether it's necessary to have this here, since user can do it via Change Datasource. And if we keep this functionality on this modal, the warning message whey you are saving the change needs to change. Currently it says that "all changes will be applied to all charts" which is true if you edit Metrics, Columns or Calculated columns. But message should be different if you just edit datasource which is only applied to this chart (warning user that this chart might break if their new datasource doesn't include same columns, but not warning user about other charts)   ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
