junlincc commented on issue #11190: URL: https://github.com/apache/incubator-superset/issues/11190#issuecomment-708526752
I agree that this functionality is a bit redundant and if we keep it modal, the warning message should be either louder and more specific. Zuzana, let's explore a better solution after getting the bug fix. Thanks for suggesting! On Wed, Oct 14, 2020 at 9:39 AM zuzana-vej <[email protected]> wrote: > So basically editing dataset on the edit dataset modal (screenshot in my > previous message) will be applied locally to the chart. It's just another > way to do it (in case user is already on the modal). I think that makes > sense. I question whether it's necessary to have this here, since user can > do it via Change Datasource. > > And if we keep this functionality on this modal, the warning message whey > you are saving the change needs to change. Currently it says that "all > changes will be applied to all charts" which is true if you edit Metrics, > Columns or Calculated columns. But message should be different if you just > edit datasource which is only applied to this chart (warning user that this > chart might break if their new datasource doesn't include same columns, but > not warning user about other charts) > > [image: Screen Shot 2020-10-14 at 9 36 48 AM] > <https://user-images.githubusercontent.com/61221714/96019207-10877100-0e01-11eb-85db-a76216ca6fd2.png> > [image: Screen Shot 2020-10-14 at 9 36 56 AM] > <https://user-images.githubusercontent.com/61221714/96019212-13826180-0e01-11eb-91c7-f9c542a02285.png> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-superset/issues/11190#issuecomment-708521731>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AQFR5U67MUHECJCDOWTO2FDSKXH3NANCNFSM4SHWCEXA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
