eschutho opened a new pull request #11289:
URL: https://github.com/apache/incubator-superset/pull/11289


   ### SUMMARY
   This fixes the revert of 
https://github.com/apache/incubator-superset/pull/11181: some visual elements 
broke from changes during the review. It would be great to add some visual 
testing in the future.. will look into that!
   Also, it was pointed out that the user should be able to type in the field 
instead of just using the popup selector. Thanks for that feedback, so I 
changed this to a placeholder. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
![Box_plot](https://user-images.githubusercontent.com/5186919/96160993-8f48e080-0ecb-11eb-8b11-c2dd1f44a4c1.png)
   
   
   ### TEST PLAN
   New jest unit tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to