ktmud opened a new pull request #11293: URL: https://github.com/apache/incubator-superset/pull/11293
### SUMMARY This fixes a bug where dashboard cache used while visiting dashboard via slug is not updated when editing an embedded chart. I used `dashboard.slug` in the default dashboard `__repr__` string because I wanted to make it human readable, but since this is mostly used in cache and not all dashboards have slugs, human readability doesn't really matter. It's more important to have stable cache keys. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TEST PLAN 1. Enable `DASHBOARD_CACHE` feature flag 2. Visit a dashboard with slug 3. Edit a chart in the dashboard 4. In base you will not see the chart updates when you return to dashboard and refresh. After the fix, the chart in dashboard should be updated. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #11273 #11234 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
