eschutho opened a new pull request #10834: URL: https://github.com/apache/incubator-superset/pull/10834
### SUMMARY Some functionality on dashboard edit isn't being properly updated in the UI after save, although it is being saved to the DB and shows up on a refresh. Some items that this fixes: Dashboard Title when edited in the modal does not refresh on save (done) Empty json metadata errors silently (done) If colorScheme is edited in json metadata, it should also update the dropdown in the edit modal and take precedence(done) label colors in json metadata are not saving properly (done) Also added wrapping to the json metadata window. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF  Save title and update color scheme  changing color scheme in metadata updates the dropdown  changing label color in metadata persists after save. You still need to refresh in order to see it updated in the chart, but we can fix that separately.  invalid color scheme string in json metadata shows an error ### TEST PLAN Cypress tests ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/incubator-superset/issues/10655 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
