rusackas commented on a change in pull request #11296: URL: https://github.com/apache/incubator-superset/pull/11296#discussion_r506734833
########## File path: superset-frontend/src/views/CRUD/csstemplates/CssTemplateModal.tsx ########## @@ -0,0 +1,258 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { FunctionComponent, useState, useEffect } from 'react'; +import { styled, t } from '@superset-ui/core'; +import { useSingleViewResource } from 'src/views/CRUD/hooks'; + +import Icon from 'src/components/Icon'; +import Modal from 'src/common/components/Modal'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; +import { CssEditor } from 'src/components/AsyncAceEditor'; + +import { TemplateObject } from './types'; + +interface CssTemplateModalProps { + addDangerToast: (msg: string) => void; + cssTemplate?: TemplateObject | null; + onCssTemplateAdd?: (cssTemplate?: TemplateObject) => void; + onHide: () => void; + show: boolean; +} + +const StyledCssTemplateTitle = styled.div` + margin: ${({ theme }) => theme.gridUnit * 2}px auto + ${({ theme }) => theme.gridUnit * 4}px auto; +`; + +const StyledCssEditor = styled(CssEditor)` + border-radius: ${({ theme }) => theme.borderRadius}px; + border: 1px solid ${({ theme }) => theme.colors.secondary.light2}; +`; + +const StyledIcon = styled(Icon)` + margin: auto ${({ theme }) => theme.gridUnit * 2}px auto 0; +`; + +const TemplateContainer = styled.div` + margin-bottom: ${({ theme }) => theme.gridUnit * 10}px; + + .control-label { + margin-bottom: ${({ theme }) => theme.gridUnit * 2}px; + } + + .required { + margin-left: ${({ theme }) => theme.gridUnit / 2}px; + color: ${({ theme }) => theme.colors.error.base}; + } + + input[type='text'] { + padding: ${({ theme }) => theme.gridUnit * 1.5}px + ${({ theme }) => theme.gridUnit * 2}px; + border: 1px solid ${({ theme }) => theme.colors.grayscale.light2}; + border-radius: ${({ theme }) => theme.gridUnit}px; + width: 50%; + } +`; + +const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({ + addDangerToast, + onCssTemplateAdd, + onHide, + show, + cssTemplate = null, +}) => { + const [disableSave, setDisableSave] = useState<boolean>(true); + const [ + currentCssTemplate, + setCurrentCssTemplate, + ] = useState<TemplateObject | null>(null); + const [isHidden, setIsHidden] = useState<boolean>(true); + const isEditMode = cssTemplate !== null; + + // cssTemplate fetch logic + const { + state: { loading, resource }, + fetchResource, + createResource, + updateResource, + } = useSingleViewResource<TemplateObject>( + 'css_template', + t('css_template'), + addDangerToast, + ); + + // Functions + const hide = () => { + setIsHidden(true); + onHide(); + }; + + const onSave = () => { + if (isEditMode) { + // Edit + if (currentCssTemplate && currentCssTemplate.id) { + const update_id = currentCssTemplate.id; + delete currentCssTemplate.id; + delete currentCssTemplate.created_by; + updateResource(update_id, currentCssTemplate).then(() => { + if (onCssTemplateAdd) { + onCssTemplateAdd(); + } + + hide(); + }); + } + } else if (currentCssTemplate) { + // Create + createResource(currentCssTemplate).then(() => { + if (onCssTemplateAdd) { + onCssTemplateAdd(); + } + + hide(); + }); + } + }; + + const onTemplateNameChange = (event: React.ChangeEvent<HTMLInputElement>) => { + const { target } = event; + + const data = { + ...currentCssTemplate, + template_name: currentCssTemplate ? currentCssTemplate.template_name : '', + css: currentCssTemplate ? currentCssTemplate.css : '', + }; + + data[target.name] = target.value; + setCurrentCssTemplate(data); + }; + + const onCssChange = (css: string) => { + const data = { + ...currentCssTemplate, + template_name: currentCssTemplate ? currentCssTemplate.template_name : '', + css, + }; + setCurrentCssTemplate(data); + }; + + const validate = () => { + if ( + currentCssTemplate && + currentCssTemplate.template_name.length && + currentCssTemplate.css && + currentCssTemplate.css.length + ) { + setDisableSave(false); + } else { + setDisableSave(true); + } + }; + + // Initialize + if ( + isEditMode && + (!currentCssTemplate || + !currentCssTemplate.id || + (cssTemplate && cssTemplate.id !== currentCssTemplate.id) || + (isHidden && show)) + ) { + if (cssTemplate && cssTemplate.id !== null && !loading) { + const id = cssTemplate.id || 0; + + fetchResource(id).then(() => { + setCurrentCssTemplate(resource); + }); + } + } else if ( + !isEditMode && + (!currentCssTemplate || currentCssTemplate.id || (isHidden && show)) + ) { + setCurrentCssTemplate({ + template_name: '', + css: '', + }); + } + + // Validation + useEffect(() => { + validate(); + }, [ + currentCssTemplate ? currentCssTemplate.template_name : '', + currentCssTemplate ? currentCssTemplate.css : '', + ]); + + // Show/hide + if (isHidden && show) { + setIsHidden(false); + } + + return ( + <Modal + disablePrimaryButton={disableSave} + onHandledPrimaryAction={onSave} + onHide={hide} + primaryButtonName={isEditMode ? t('Save') : t('Add')} + show={show} + width="800px" Review comment: FWIW, we can do some fun stuff with this, e.g. `width={"calc(100% - 100px)"}` if you ever feel like it :D If/when there are a lot of these modals kicking around, we should probably add a limited number of preferred values to the Theme or a constants file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
