adam-stasiak opened a new pull request #11327:
URL: https://github.com/apache/incubator-superset/pull/11327
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I added babel plugin for production debug babel variant - it trims data-test
from production code. It requires passing BABEL_ENV=production while building
prod.
I observed that it is not applicable for inputProps:
``` <div style={{ margin: '5px 0' }}>
<Datetime
inputProps={{ 'data-test': 'date-from-input' }}```
and for code in templates in superset/ directory:
``` <!-- Modal for misc messages / alerts -->
<div class="misc-modal modal fade" tabindex="-1" role="dialog"
aria-labelledby="myModalLabel">
<div class="modal-dialog" role="document">
<div class="modal-content" data-test="modal-content">
<div class="modal-header" data-test="modal-header">
<button type="button" class="close" data-dismiss="modal"
aria-label="Close" data-test="modal-header-close-button">```
It is working for
``` const trs = [
<tr {...{ 'data-test': 'table-row' }} className="row" key={record.id}>
{tds}
</tr>,```
So I think the next step is to wrap somehow elements from superset/ and
replace inputProps with some other wrapper for elements.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
