zuzana-vej edited a comment on issue #10655: URL: https://github.com/apache/incubator-superset/issues/10655#issuecomment-712528282
No, it didn't. Right now, (after #11220 merged) this is what happens if user tries to edit dashboard metadata (e.g. best way to test this on your test dashboard is to change color of one of the lines on your chart in the dashboard metadata tab). Right now, what happens, is: 1. user edits metatada (e.g. change color of a line on a chart) 2. user clicks save on modal (all good) 3. user clicks save on dashboard --> and gets the message "this dashboard has changed, please reload" 4. when user reloads, user can see the change actually got applied Steps 3+4 will confuse them currently. So in a way it solves the issue - change is applied, but user currently gets a warning message which will confuse them. Actually if we want to be really precise, this issue is resolved, but with #11220 there is new issue now. I am not sure if this open PR would solve what is happening now? this is how I test - by changing one of these values: <img width="718" alt="Screen Shot 2020-10-19 at 6 12 58 PM" src="https://user-images.githubusercontent.com/61221714/96528368-6449ee00-1237-11eb-9132-8a0361b05e31.png";> cc: @graceguo-supercat ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/61221714/96528368-6449ee00-1237-11eb-9132-8a0361b05e31.png"](https://user-images.githubusercontent.com/61221714/96528368-6449ee00-1237-11eb-9132-8a0361b05e31.png"){kind=link}