rusackas commented on a change in pull request #11160:
URL:
https://github.com/apache/incubator-superset/pull/11160#discussion_r508199620
##########
File path:
superset-frontend/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx
##########
@@ -53,16 +55,19 @@ describe('Tabs', () => {
deleteComponent() {},
updateComponents() {},
logEvent() {},
+ setMountedTab() {},
};
function setup(overrideProps) {
// We have to wrap provide DragDropContext for the underlying DragDroppable
// otherwise we cannot assert on DragDroppable children
const wrapper = mount(
<Provider store={mockStoreWithTabs}>
- <WithDragDropContext>
- <Tabs {...props} {...overrideProps} />
- </WithDragDropContext>
+ <ThemeProvider theme={supersetTheme}>
Review comment:
If you'd rather not import the `supersetTheme` and `ThemeProvider` to
use here, you can instead `import { styledMount as mount } from
'spec/helpers/theming'` and then just do
```
<Provider store={mockStoreWithTabs}>
<WithDragDropContext>
<Tabs {...props} {...overrideProps} />
</WithDragDropContext>
</Provider>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
