rusackas commented on pull request #11160: URL: https://github.com/apache/incubator-superset/pull/11160#issuecomment-712579357
In the last conversation I had with designers about this, the conclusion was: • We should use the same style of tabs in presentation and edit mode • Therefore, if we need to use the card-based tabs in edit mode, then we should use that style of tabs in both modes. • It would be _great_ if we can then _style_ those tabs to make them look like the underlined AntD tabs we're starting to add to other views. • If that styling change needs to happen in another PR, so we can get this one across the finish line, so be it. Any objections to the above? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
