eschutho commented on a change in pull request #11207:
URL: 
https://github.com/apache/incubator-superset/pull/11207#discussion_r508709580



##########
File path: docker/docker-init.sh
##########
@@ -59,3 +60,38 @@ if [ "$SUPERSET_LOAD_EXAMPLES" = "yes" ]; then
     superset load_examples
     echo_step "4" "Complete" "Loading examples"
 fi
+}
+
+with_cypress(){
+    # Configure environment
+    echo_step "1" "Starting" "Configuring environment for Cypress"
+    sed -i '/ENABLE_REACT_CRUD_VIEWS = False/c\ENABLE_REACT_CRUD_VIEWS = True' 
/app/superset/config.py
+    sed -i '/ENABLE_REACT_CRUD_VIEWS = 
os.environ.get("ENABLE_REACT_CRUD_VIEWS", False)/c\ENABLE_REACT_CRUD_VIEWS = 
True' /app/tests/superset_test_config.py

Review comment:
       same thing here. I don't think we want to update the files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to