hughhhh commented on a change in pull request #11349: URL: https://github.com/apache/incubator-superset/pull/11349#discussion_r509394983
########## File path: superset/charts/commands/export.py ########## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# isort:skip_file + +import json +from typing import Iterator, List, Tuple + +import yaml + +from superset.commands.base import BaseCommand +from superset.charts.commands.exceptions import ChartNotFoundError +from superset.charts.dao import ChartDAO +from superset.datasets.commands.export import ExportDatasetsCommand +from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize +from superset.models.slice import Slice + + +# keys present in the standard export that are not needed +REMOVE_KEYS = ["datasource_type", "datasource_name"] + + +class ExportChartsCommand(BaseCommand): + def __init__(self, chart_ids: List[int]): + self.chart_ids = chart_ids + + # this will be set when calling validate() + self._models: List[Slice] = [] + + @staticmethod + def export_chart(chart: Slice) -> Iterator[Tuple[str, str]]: + chart_slug = sanitize(chart.slice_name) + file_name = f"charts/{chart_slug}.yaml" + + payload = chart.export_to_dict( + recursive=False, + include_parent_ref=False, + include_defaults=True, + export_uuids=True, + ) + # TODO (betodealmeida): move this logic to export_to_dict once this + # becomes the default export endpoint + for key in REMOVE_KEYS: + del payload[key] + if "params" in payload: + try: + payload["params"] = json.loads(payload["params"]) + except json.decoder.JSONDecodeError: + pass Review comment: add logger.warn to know loading the params object failed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
