rusackas commented on a change in pull request #11340:
URL:
https://github.com/apache/incubator-superset/pull/11340#discussion_r509559876
##########
File path: superset/config.py
##########
@@ -308,6 +308,12 @@ def _try_json_readsha( # pylint: disable=unused-argument
"TAGGING_SYSTEM": False,
"SQLLAB_BACKEND_PERSISTENCE": False,
"LISTVIEWS_DEFAULT_CARD_VIEW": False,
+
+ # When set to True, this flag allows display of HTML tags in Markdown
components
+ "DISPLAY_MARKDOWN_HTML": True,
+
+ # When True, this escapes HTML (rather than rendering it) in Markdown
components
+ "ESCAPE_MARKDOWN_HTML": False,
Review comment:
I don't _believe_ there are any security issues that exist in this
implementation.
The reason these flags aren't flipped here is that it would cause the
example dashboards (and perhaps customer/user dashboards) to suddenly look very
broken, with a bunch of noisy HTML displayed, or (in the examples) nothing
displayed at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
