rusackas commented on pull request #11206: URL: https://github.com/apache/incubator-superset/pull/11206#issuecomment-714288002
A few other little things that we discussed in person. They should not be blockers here, and could be followed up on other PRs, but I wanted to put them "on paper": * It would be great to share/reuse the media queries with cards (keeping it DRY), so they benefit other card views. * Maybe instead of living in `superset-frontend/src/views/CRUD/welcome` it should live in `superset-frontend/src/views/welcome` as its own thing. * If _may be of benefit to decouple all the card variants (Recent/Chart/Dashboard/SavedQuery/(eventually...)SearchResult). If doing so, then they should _all_ probably continue to use the common `ListVIewCard` under the hood, which could be renamed as `BaseCard` or similar. All of these could live in the main `components` directory, perhaps hierarchically nested. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
