adam-stasiak opened a new pull request #11402:
URL: https://github.com/apache/incubator-superset/pull/11402
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I fixed tests in query.test.ts file. it('successfully saves a query', ()
=> { required deep changes - only way I saw to open saved sql query was in new
tab - cypress does not support this easily (ok supports but trick with href
does not work in this case) so I visit url created in test and then verify
final assertions.
I removed wait on requests - > with only one request it was unstable on my
computer - one request was faster than cypress and it was waiting for already
finished request.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
