kgabryje opened a new pull request #11428: URL: https://github.com/apache/incubator-superset/pull/11428
### SUMMARY Fixes issues https://github.com/apache/incubator-superset/issues/11388 and https://github.com/apache/incubator-superset/issues/11404. Changes in `AdhocFilterOption` might be in conflict with https://github.com/apache/incubator-superset/pull/11412 by @mistercrunch - unfortunately it seems that mutating a `adhocFilter.isNew` prop is necessary until we do a deeper refactor. Simply making that prop a part of the state leads to various issues regarding auto-opening the popup when new filter is added - particularly when there are multiple unsaved filters. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF As shown on the gif, the popup opens automatically and typing spaces and comas works properly.  ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/incubator-superset/issues/11388, https://github.com/apache/incubator-superset/pull/11412 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
