villebro opened a new pull request #11429: URL: https://github.com/apache/incubator-superset/pull/11429
### SUMMARY `TableColumn` has three properties to check the datatype of a column: `is_numeric`, `is_string` and `is_temporal`. `is_temporal` is usually referenced when a new dataset is added to populate default values for `is_dttm`, which indicates whether or not a column is to added to the time column dropdown. This changes the behaviour of `is_temporal` to first check the value of `is_dttm`, and if that is set, return that value, otherwise check the datatype. The placeholder text is also fixed, as it featured non-compliant syntax (Year is `%Y`, not `y`). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN Added test. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
