ktmud commented on a change in pull request #11435:
URL:
https://github.com/apache/incubator-superset/pull/11435#discussion_r512332312
##########
File path: superset-frontend/src/explore/components/Control.tsx
##########
@@ -27,7 +27,7 @@ import './Control.less';
export type ControlProps = {
// the actual action dispatcher (via bindActionCreators) has identical
// signature to the original action factory.
- actions: ExploreActions;
+ actions: Partial<ExploreActions> & Pick<ExploreActions, 'setControlValue'>;
Review comment:
setControlValue is required (as is used in FilterBox), all other actions
are optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
