kgabryje commented on a change in pull request #11118:
URL:
https://github.com/apache/incubator-superset/pull/11118#discussion_r512730241
##########
File path:
superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -17,12 +17,12 @@
* under the License.
*/
import React from 'react';
-import { Tabs } from 'react-bootstrap';
import { shallow } from 'enzyme';
import configureStore from 'redux-mock-store';
import fetchMock from 'fetch-mock';
import thunk from 'redux-thunk';
+import Tabs from 'src/common/components/Tabs';
Review comment:
Done. Other components in `/common/components` should be refactored the
same way, but I suggest we do that in a separate PR.
I tried to move stories from `common.stories.tsx` to
`Tabs/tabs.stories.tsx`, but it did not work - they didn't appear in
Storybook's nav menu. Is that a known bug? In `.storybook/main.js` there's a
line `stories: ['../src/@(components|common)/**/*.stories.@(t|j)sx']` which
seems to cover the cases of stories in sub dirs, but I think it doesn't work as
expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
