nytai commented on issue #11266: URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717641569
ok, I see what the discrepancy is here. The label of "Physical" and "Virtual" is based on the presence of the `sql` attribute (see https://github.com/apache/incubator-superset/blob/155b5edec131d71eb392ee52f9bf97de495c2ef0/superset/connectors/base/models.py#L116). Meanwhile the filter for "Physical" and "Virtual" is based on the `is_sqllab_view` flag (see https://github.com/apache/incubator-superset/blob/155b5edec131d71eb392ee52f9bf97de495c2ef0/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx#L353). So the question is, which attribute determines if it's a "virtual" dataset? The presence of the `sql` attribute or the `is_sqllab_view` attribute? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
