etr2460 commented on a change in pull request #11445:
URL:
https://github.com/apache/incubator-superset/pull/11445#discussion_r513157852
##########
File path:
superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends
React.Component {
clearable
closeOnSelect
onChange={this.onChange}
+ onPaste={() => {}}
Review comment:
ah yeah, you're totally right. I was mistaken from this eslint rule:
https://eslint.org/docs/rules/no-empty-function where they preferred `() =>
undefined` as it's more obvious that the function is meant to be empty.
That said, it looks like we've defined noOp in a utils file already, so we
should probably use that:
https://github.com/apache/incubator-superset/blob/ccfd293227105ae1a5a24999a3b75e3db724273b/superset-frontend/src/utils/common.js#L139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
