ktmud opened a new pull request #11481:
URL: https://github.com/apache/incubator-superset/pull/11481


   ### SUMMARY
   
   The `/recent_actively` API now almost always returns empty arrays. We don't 
know how long has it been broken but it seems the intention was to show 
dashboards and charts users recently viewed.
   
   This PR fixes this API endpoint by using the correct logging actions for the 
Explore and Dashboard page.
   
   This endpoint is used on the `/superset/welcome` page and user profile page. 
Since PR #11206 will make the recently viewed info more prominent, it is 
important to get this fixed.
   
   I also added a "distinct" mode (which is the default and can be turned off 
by setting `distinct=false`) that will return only distinct subjects with their 
latest viewed date.
   
   Currently I'm just throwing stuff in the `views/core.py` file, it might 
worth creating a `superset.users` module and migrating this to a new 
better-tested and better-documented API endpoint in the future.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   
![Snip20201029_114](https://user-images.githubusercontent.com/335541/97543600-b2709700-1985-11eb-955a-7c661b60296d.png)
   
   #### After
   
   
![Snip20201029_113](https://user-images.githubusercontent.com/335541/97543608-b56b8780-1985-11eb-81cd-f69d04649227.png)
   
   
   ### TEST PLAN
   
   Manual
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @pkdotson @rusackas @nytai @villebro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to