ktmud commented on a change in pull request #11206:
URL:
https://github.com/apache/incubator-superset/pull/11206#discussion_r514004665
##########
File path: superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
##########
@@ -16,169 +16,176 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React from 'react';
-import { t, SupersetClient } from '@superset-ui/core';
-import { debounce } from 'lodash';
-import ListView, { FetchDataConfig } from 'src/components/ListView';
+import React, { useEffect, useState } from 'react';
+import { SupersetClient, t } from '@superset-ui/core';
+import { useListViewResource } from 'src/views/CRUD/hooks';
+import { Dashboard, DashboardTableProps } from 'src/views/CRUD/types';
import withToasts from 'src/messageToasts/enhancers/withToasts';
-import { Dashboard } from 'src/types/bootstrapTypes';
+import PropertiesModal from 'src/dashboard/components/PropertiesModal';
+import DashboardCard from 'src/views/CRUD/dashboard/DashboardCard';
+import SubMenu from 'src/components/Menu/SubMenu';
+import Icon from 'src/components/Icon';
+import EmptyState from './EmptyState';
+import { createErrorHandler, CardContainer, IconContainer } from '../utils';
-const PAGE_SIZE = 25;
+const PAGE_SIZE = 3;
-interface DashboardTableProps {
- addDangerToast: (message: string) => void;
- search?: string;
+export interface FilterValue {
+ col: string;
+ operator: string;
+ value: string | boolean | number | null | undefined;
}
-interface DashboardTableState {
- dashboards: Dashboard[];
- dashboard_count: number;
- loading: boolean;
-}
+function DashboardTable({
+ user,
+ addDangerToast,
+ addSuccessToast,
+}: DashboardTableProps) {
+ const {
+ state: { loading, resourceCollection: dashboards, bulkSelectEnabled },
+ setResourceCollection: setDashboards,
+ hasPerm,
+ refreshData,
+ fetchData,
+ } = useListViewResource<Dashboard>(
+ 'dashboard',
+ t('dashboard'),
+ addDangerToast,
+ );
-class DashboardTable extends React.PureComponent<
- DashboardTableProps,
- DashboardTableState
-> {
- columns = [
- {
- accessor: 'dashboard_title',
- Header: 'Dashboard',
- Cell: ({
- row: {
- original: { url, dashboard_title: dashboardTitle },
- },
- }: {
- row: {
- original: {
- url: string;
- dashboard_title: string;
- };
- };
- }) => <a href={url}>{dashboardTitle}</a>,
- },
- {
- accessor: 'changed_by.first_name',
- Header: 'Modified By',
- Cell: ({
- row: {
- original: { changed_by_name: changedByName, changedByUrl },
- },
- }: {
- row: {
- original: {
- changed_by_name: string;
- changedByUrl: string;
- };
- };
- }) => <a href={changedByUrl}>{changedByName}</a>,
- },
- {
- accessor: 'changed_on_delta_humanized',
- Header: 'Modified',
- Cell: ({
- row: {
- original: { changed_on_delta_humanized: changedOn },
- },
- }: {
- row: {
- original: {
- changed_on_delta_humanized: string;
- };
- };
- }) => <span className="no-wrap">{changedOn}</span>,
- },
- ];
+ const [editModal, setEditModal] = useState<Dashboard | null>(null);
Review comment:
I'm also not sure about opening the Dashboard Properties modal with this
link.
<img
src="https://user-images.githubusercontent.com/335541/97531800-34ef5b80-1972-11eb-874f-d735aef3d169.png";
width="300">
It should probably just open the dashboard page in edit mode in a new window
instead (`/superset/dashboard/${dashboard.id}/?edit=true`), since editing
dashboard layout/charts is a much more common action than editing dashboard
properties.
I would probably also change the order of the links to "Edit > Export >
Delete".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/97531800-34ef5b80-1972-11eb-874f-d735aef3d169.png"](https://user-images.githubusercontent.com/335541/97531800-34ef5b80-1972-11eb-874f-d735aef3d169.png"){kind=link}