rusackas commented on a change in pull request #11491:
URL:
https://github.com/apache/incubator-superset/pull/11491#discussion_r514620658
##########
File path: superset-frontend/src/common/components/index.tsx
##########
@@ -17,16 +17,35 @@
* under the License.
*/
import { styled } from '@superset-ui/core';
+// eslint-disable-next-line no-restricted-imports
import { Skeleton } from 'antd';
+import AntdMenuItem from 'antd/lib/menu/MenuItem';
/*
- Antd is exported from here so we can override components with Emotion as
needed.
+ Antd is re-exported from here so we can override components with Emotion as
needed.
For documentation, see https://ant.design/components/overview/
*/
-/* eslint no-restricted-imports: 0 */
+// eslint-disable-next-line no-restricted-imports
+export {
+ Avatar,
+ Card,
+ Collapse,
+ Empty,
+ Dropdown,
+ Menu,
+ Modal,
+ Popover,
+ Skeleton,
+ Tabs,
+ Tooltip,
+} from 'antd';
-export * from 'antd';
+export const MenuItem = styled(AntdMenuItem)`
Review comment:
Ahh, wasn't aware of the typing issues with this approach... I wonder if
there's a good way to mitigate that, as I like the ability to just bolt on
`styled` parts as needed.
Totally agree with your plan around the explicit antd exports and
importing/exporting the other overrides from there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
