suddjian commented on a change in pull request #11501:
URL:
https://github.com/apache/incubator-superset/pull/11501#discussion_r516162219
##########
File path:
superset-frontend/spec/javascripts/dashboard/components/PropertiesModal_spec.jsx
##########
@@ -87,14 +87,14 @@ describe('PropertiesModal', () => {
const modalInstance = wrapper.find('PropertiesModal').instance();
modalInstance.setState({
values: {
- json_metadata: '{"color_scheme":"foo"}',
+ json_metadata: '{"color_scheme": "foo"}',
Review comment:
I think that would test the behavior of the json formatting function
more than it would test our code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
