ktmud commented on a change in pull request #11509: URL: https://github.com/apache/incubator-superset/pull/11509#discussion_r516180923
########## File path: UPDATING.md ########## @@ -16,292 +16,300 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> + # Updating Superset This file documents any backwards-incompatible changes in Superset and assists people when migrating to a new version. ## Next -* NOTICE: config flag ENABLE_REACT_CRUD_VIEWS has been set to `True` by default, set to `False` if - you prefer to vintage look and feel :) +- [11509](https://github.com/apache/incubator-superset/pull/11509): Config value `TABLE_NAMES_CACHE_CONFIG` has been renamed to `DATA_CACHE_CONFIG`, which will now also hold query results cache from connected datasources (previously held in `CACHE_CONFIG`), in addition to the table names. If you will set `DATA_CACHE_CONFIG` to a new cache backend different than your previous `CACHE_CONFIG`, plan for additional cache warmup to avoid degrading charting performance for the end users. + +- [11259](https://github.com/apache/incubator-superset/pull/11259): config flag ENABLE_REACT_CRUD_VIEWS has been set to `True` by default, set to `False` if you prefer to the vintage look and feel :) -* [11244](https://github.com/apache/incubator-superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months. +- [11244](https://github.com/apache/incubator-superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months. Review comment: Updated by my Markdown linter.. Only changes `*` to `-`. ########## File path: superset/models/dashboard.py ########## @@ -254,7 +254,6 @@ def data(self) -> Dict[str, Any]: @cache.memoize( # manage cache version manually make_name=lambda fname: f"{fname}-v2.1", - timeout=config["DASHBOARD_CACHE_TIMEOUT"], Review comment: This cache will use the global default timeout from `CACHE_CONFIG` as I don't see a strong reason to give a different timeout. ########## File path: superset/utils/cache_manager.py ########## @@ -23,17 +23,35 @@ def __init__(self) -> None: super().__init__() self._cache = Cache() - self._tables_cache = Cache() + self._data_cache = Cache() self._thumbnail_cache = Cache() def init_app(self, app: Flask) -> None: - self._cache.init_app(app, app.config["CACHE_CONFIG"]) - self._tables_cache.init_app(app, app.config["TABLE_NAMES_CACHE_CONFIG"]) - self._thumbnail_cache.init_app(app, app.config["THUMBNAIL_CACHE_CONFIG"]) + self._cache.init_app( + app, + { + "CACHE_DEFAULT_TIMEOUT": app.config["CACHE_DEFAULT_TIMEOUT"], Review comment: Make sure the global default is applied as documented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
