betodealmeida opened a new pull request #11532: URL: https://github.com/apache/incubator-superset/pull/11532
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> For the new export functionality (https://github.com/apache/incubator-superset/issues/11167) I implemented a new function called `sanitize` that takes a model ID and generates a directory name by removing spaces and other special characters. Later, I discovered that werkzeug already offers a function called [secure_filename](https://tedboy.github.io/flask/generated/werkzeug.secure_filename.html) that is better. This PR replaces `sanitize` with `secure_filename`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TEST PLAN <!--- What steps should be taken to verify the changes --> Unit tests pass. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
