betodealmeida commented on a change in pull request #11533:
URL:
https://github.com/apache/incubator-superset/pull/11533#discussion_r516807806
##########
File path: superset/dashboards/commands/importers/v0.py
##########
@@ -324,7 +325,7 @@ def run(self) -> None:
self.validate()
for file_name, content in self.contents.items():
- logger.info(f"Importing dashboard from file {file_name}")
+ logger.info("Importing dashboard from file %s", file_name)
Review comment:
@hughhhh when logging pylint actually [recommends string
interpolation](https://github.com/PyCQA/pylint/issues/1788), since it's faster
(the string is interpolated only if the log level is being recorded) and safer
(if the string interpolation fails something is still logged). I changed it
here because pylint was complaining.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
