suddjian opened a new pull request #11558: URL: https://github.com/apache/incubator-superset/pull/11558
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This is more of a patch fix. The true underlying problem is a bad state design for the "switching between tabs" state but I don't have the bandwidth to address that right now. The reason this fix works/is necessary is that `gridComponents/Chart`'s `shouldComponentUpdate` function uses `mountedTab === null` state to check whether the chart should render. This is a bad way to manage state, hence this bug. But it is what it is. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> Tested locally. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #11542 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
