rusackas commented on pull request #11602: URL: https://github.com/apache/incubator-superset/pull/11602#issuecomment-723251225
Obviously this is one contentious line of CSS! Some of us like shorter chart headers... some of us don't. I can see a few ways to tackle things like it in the future: 1) More feature flags... though many of us are not fans of adding a bunch of feature flags for tiny CSS changes, the option exists 2) Adding a custom style sheet somewhere - think of it as a config file, where you can just override some things like this. This could get fragile quickly, so it would be a "use at your own risk" thing. 3) Adding a user preferences area... though not all that different from feature flags, at least the _user_ gets the choice. 4) Bringing this sort of thing back to the community as DISCUSS and VOTE threads. We have a governance model for a good reason :) The important thing (to me anyway) is that Superset is going to have a lot of changes... we need to get better at: • Considering design proposals before approving, so we don't have to backtrack later • Surfacing feedback from users in a constructive way, as early as possible • _Iterating_ on features when we can, to prevent big reverts over small details. • Staying friends through all of this! ❤️ All of your hard work and input is valued here. Thanks, everyone. ... but again, much ado about _just one line_... merging! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
