rusackas opened a new pull request #11611:
URL: https://github.com/apache/incubator-superset/pull/11611


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   POC of one way to style the antd popover. to have a dark background & arrow.
   
   In general, it looks about right:
   
![image](https://user-images.githubusercontent.com/812905/98434306-5db6d580-2083-11eb-906c-b328bb7baa85.png)
   
   But... there's a dangerous side effect: it uses global CSS, so if there's 
another popover somewhere on the same screen, it gets the same styling. I don't 
_think_ that's a situation that exists today, but it _might_ at some point. Not 
sure of another way around this, yet. Ideas, anyone?
   
   
![image](https://user-images.githubusercontent.com/812905/98434300-54c60400-2083-11eb-8243-fac4ac47ab19.png)
   
   FYI @suddjian @kgabryje 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   See above
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Added an extra popover to the UI to confirm the problem. I'll add a 
storybook entry to test that as well.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to